Skip to content

chore: fix deprecation warnings - #485

Merged
samuelallan72 merged 1 commit into
masterfrom
deprecation-warnings
Nov 9, 2026
Merged

samuelallan72 merged 1 commit into
masterfrom
deprecation-warnings

Conversation

@bradenmacdonald

@bradenmacdonald bradenmacdonald commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

This fixes a bunch of minor deprecation warnings, e.g.:

/mnt/xblock-problem-builder/problem_builder/mentoring.py:36: DeprecatedPackageWarning:
Please use import xblock.utils.settings instead of xblockutils.settings because the 'xblock-utils' package
has been deprecated and migrated to within 'xblock' package

The tests still use from xblock.utils.base_test import SeleniumBaseTest, SeleniumXBlockTest because there is no replacement for that.

@codecov

codecov Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.04%. Comparing base (253460a) to head (69c5b87).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #485   +/-   ##
=======================================
  Coverage   45.04%   45.04%           
=======================================
  Files          40       40           
  Lines        3303     3303           
  Branches      401      401           
=======================================
  Hits         1488     1488           
  Misses       1768     1768           
  Partials       47       47           
Flag Coverage Δ
unittests 45.04% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bradenmacdonald

Copy link
Copy Markdown
Member Author

@samuelallan72 FYI. I wanted to submit a quick fix here, but it looks like there's a bunch of other existing issues causing the tests not to pass.

@samuelallan72

Copy link
Copy Markdown
Member

@bradenmacdonald ah nice! I think these tests will start passing when #484 is merged. Let me merge that, then you can rebase and see how it goes. :)

@bradenmacdonald
bradenmacdonald force-pushed the deprecation-warnings branch 2 times, most recently from 6235e2d to 05a5df8 Compare November 9, 2026 16:55
@bradenmacdonald

Copy link
Copy Markdown
Member Author

@samuelallan72 Thanks! Looks like this is green now. Could you please approve and merge?

@samuelallan72 samuelallan72 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: read the changes, verified low risk changes, verified the tests pass
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@samuelallan72
samuelallan72 merged commit 7d2a272 into master Nov 9, 2026
9 checks passed
@samuelallan72
samuelallan72 deleted the deprecation-warnings branch November 9, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants