Repository navigation
chore: fix deprecation warnings - #485
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #485 +/- ##
=======================================
Coverage 45.04% 45.04%
=======================================
Files 40 40
Lines 3303 3303
Branches 401 401
=======================================
Hits 1488 1488
Misses 1768 1768
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
@samuelallan72 FYI. I wanted to submit a quick fix here, but it looks like there's a bunch of other existing issues causing the tests not to pass. |
Member
|
@bradenmacdonald ah nice! I think these tests will start passing when #484 is merged. Let me merge that, then you can rebase and see how it goes. :) |
bradenmacdonald
force-pushed
the
deprecation-warnings
branch
2 times, most recently
from
November 9, 2026 16:55
6235e2d to
05a5df8
Compare
bradenmacdonald
force-pushed
the
deprecation-warnings
branch
from
November 9, 2026 16:59
05a5df8 to
69c5b87
Compare
Member
Author
|
@samuelallan72 Thanks! Looks like this is green now. Could you please approve and merge? |
samuelallan72
approved these changes
Nov 9, 2026
samuelallan72
left a comment
Member
There was a problem hiding this comment.
👍
- I tested this: read the changes, verified low risk changes, verified the tests pass
- I read through the code
- I checked for accessibility issues
- Includes documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bunch of minor deprecation warnings, e.g.:
The tests still use
from xblock.utils.base_test import SeleniumBaseTest, SeleniumXBlockTestbecause there is no replacement for that.