Repository navigation
Verbraucher: Fix Lastmanagement-Nachricht bei Überschuss-Laden - #4173
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed changes address the stated behavior and include focused regression tests with no unresolved blocking issues.
No open issues 🎉
What changed in this PR
This pull request fixes misleading load-management messages during surplus-controlled charging.
Changes:
- Compare current values rounded to two decimal places.
- Handle unset previous currents and missing limit messages.
- Suppress messages when no actual limiting reason exists.
- Add parameterized regression tests for the updated behavior.
| File | Description |
|---|---|
packages/control/algorithm/surplus_controlled.py |
Refines when load-management messages are emitted during surplus charging. |
packages/control/algorithm/surplus_controlled_test.py |
Adds regression coverage for rounding, missing limits, power limits, and unset currents. |
Review effort: Lite
LKuemmel
added a commit
that referenced
this pull request
Oct 23, 2026
* Verbraucher: Fix Lastmanagement-Nachricht bei Überschuss-Laden * fix pytest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4157 (comment)