Repository navigation
Conversation
Show, above the learning header, the pathways that include the current course and in which the learner is enrolled. The labels that do not fit are moved to a "+N" popover, following the same logic as the course card strip in the learner dashboard. - Add the `course-pathways` data layer: `getPathwaysByCourse` in the API layer, which returns an empty map until the backend exists, and the `useCoursePathways` hook, which extracts the course pathways from it. - Add the `CoursePathwaysStrip` and `MorePathwaysPopover` components and the `useVisiblePathways` hook to split the visible and hidden pathways. - Add the `org.openedx.frontend.learning.course_pathways_strip.v1` plugin slot, rendered by `TabPage` once the course page has loaded. - Add mock pathways as test fixtures.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
…s strip and request its pathways
…over and align it to the end of the strip Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ip slot below the course header
…p in its own pathways-strip folder
…ourse pathways strip to them
…ate earned in the pathway
|
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2232 +/- ##
==========================================
+ Coverage 96.16% 96.29% +0.13%
==========================================
Files 368 391 +23
Lines 6019 6232 +213
Branches 1486 1462 -24
==========================================
+ Hits 5788 6001 +213
Misses 222 222
Partials 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@ChrisChV @cassiezamparini Since this PR is part of Pathways, can we consider it approved from a product perspective? |
|
Leaving this to @ChrisChV to answer :) |
@itsjeyd It's in internal dev review |
| {providerName} | ||
| </span> | ||
| <span className="small"> | ||
| <FormattedMessage {...messages.completed} values={{ date: completedOn }} /> |
There was a problem hiding this comment.
We are passing the completedOn as a plain string here.
| <FormattedMessage {...messages.completed} values={{ date: completedOn }} /> | |
| <FormattedMessage | |
| {...messages.completed} | |
| values={{ | |
| date: ( | |
| <FormattedDate | |
| value={completedOn} | |
| day="numeric" | |
| month="short" | |
| year="numeric" | |
| timeZone="UTC" // FIXME: get user timezone | |
| /> | |
| ), | |
| }} | |
| /> |
Then, we would probably need an endpoint to get the user timezone. The course code gets it from /api/course_home/v1/course_metadata/
| <span className="h4"> | ||
| {displayName} | ||
| </span> |
There was a problem hiding this comment.
Nit: <span className="h4"> gives the visual size but no heading semantics
| <span className="h4"> | |
| {displayName} | |
| </span> | |
| <h3 className="h4"> | |
| {displayName} | |
| </h3> |
| import { NewsModeIcon } from './NewsModeIcon'; | ||
|
|
||
| export interface CertificateCardProps extends PathwayAchievementData { | ||
| categoryLabel?: string; |
There was a problem hiding this comment.
I think it is safe to assume we will always have that.
| categoryLabel?: string; | |
| categoryLabel: string; |
| import { Button, Icon, Stack } from '@openedx/paragon'; | ||
| import { FormattedMessage } from '@edx/frontend-platform/i18n'; | ||
|
|
||
| import { PathwayAchievementData } from '@src/pathways/data/types'; |
There was a problem hiding this comment.
Nit
| import { PathwayAchievementData } from '@src/pathways/data/types'; | |
| import type { PathwayAchievementData } from '@src/pathways/data/types'; |
| pathwayCertificate: { | ||
| id: 'learning.pathways.certificate-card.pathway-certificate', | ||
| defaultMessage: '{categoryLabel} certificate', | ||
| description: 'Subtite of the Pathway certificate', |
There was a problem hiding this comment.
typo
| description: 'Subtite of the Pathway certificate', | |
| description: 'Subtitle of the Pathway certificate', |
| itemCertificate: { | ||
| id: 'learning.pathways.certificate-card.item-certificate', | ||
| defaultMessage: 'Certificate', | ||
| description: 'Subtite of the Item certificate', |
There was a problem hiding this comment.
typo
| description: 'Subtite of the Item certificate', | |
| description: 'Subtitle of the Item certificate', |
| completed: { | ||
| id: 'learning.pathways.certificate-card.completed', | ||
| defaultMessage: 'Completed on {date}', | ||
| description: 'Subtite of the Pathway certificate', |
There was a problem hiding this comment.
| description: 'Subtite of the Pathway certificate', | |
| description: 'Completion date for the course', |
Description
Review only the changes of this PR: open-craft/frontend-app-learning@chris/fal-4398-pathway-tabs...chris/fal-4398-pathway-achievements-page
It adds the content of the Achievements tab of the pathway pages.
Supporting information
Testing instructions
Notes
Stack