Skip to content

feat: Pathway achievements page [FC-0137] - #2232

Open
ChrisChV wants to merge 17 commits into
openedx:masterfrom
open-craft:chris/fal-4398-pathway-achievements-page
Open

ChrisChV wants to merge 17 commits into
openedx:masterfrom
open-craft:chris/fal-4398-pathway-achievements-page

Conversation

@ChrisChV

@ChrisChV ChrisChV commented Oct 29, 2026 •

Copy link
Copy Markdown

Description

Review only the changes of this PR: open-craft/frontend-app-learning@chris/fal-4398-pathway-tabs...chris/fal-4398-pathway-achievements-page

It adds the content of the Achievements tab of the pathway pages.

  • Shows a grid with a card for each certificate the learner has earned in the pathway
  • The certificate of the pathway itself is highlighted
image

Supporting information

Testing instructions

Notes

  • TODO: The backend still needs to be connected once it's ready.
  • TODO: It's missing the empty state of the achievements page. Waiting for a response.
  • TODO: The "View certificate" button does not link to the certificate yet.
  • I used Claude Opus 5.5 to review my code and create tests.

Stack

ChrisChV and others added 15 commits October 4, 2026 14:16
Show, above the learning header, the pathways that include the current
course and in which the learner is enrolled. The labels that do not fit
are moved to a "+N" popover, following the same logic as the course card
strip in the learner dashboard.

- Add the `course-pathways` data layer: `getPathwaysByCourse` in the API
  layer, which returns an empty map until the backend exists, and the
  `useCoursePathways` hook, which extracts the course pathways from it.
- Add the `CoursePathwaysStrip` and `MorePathwaysPopover` components and
  the `useVisiblePathways` hook to split the visible and hidden pathways.
- Add the `org.openedx.frontend.learning.course_pathways_strip.v1` plugin
  slot, rendered by `TabPage` once the course page has loaded.
- Add mock pathways as test fixtures.
…over and align it to the end of the strip

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 29, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Oct 29, 2026
@ChrisChV ChrisChV changed the title Chris/fal 4398 pathway achievements page feat: Pathway achievements page [FC-0137] Oct 29, 2026
@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.29%. Comparing base (230799e) to head (dca6d77).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2232      +/-   ##
==========================================
+ Coverage   96.16%   96.29%   +0.13%     
==========================================
  Files         368      391      +23     
  Lines        6019     6232     +213     
  Branches     1486     1462      -24     
==========================================
+ Hits         5788     6001     +213     
  Misses        222      222              
  Partials        9        9              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@itsjeyd

itsjeyd commented Nov 6, 2026

Copy link
Copy Markdown

@ChrisChV @cassiezamparini Since this PR is part of Pathways, can we consider it approved from a product perspective?

@itsjeyd itsjeyd moved this from Needs Triage to Waiting on Author in Contributions Nov 6, 2026
@cassiezamparini

Copy link
Copy Markdown

Leaving this to @ChrisChV to answer :)

@ChrisChV

ChrisChV commented Nov 9, 2026

Copy link
Copy Markdown
Author

@ChrisChV @cassiezamparini Since this PR is part of Pathways, can we consider it approved from a product perspective?

@itsjeyd It's in internal dev review

@rpenido rpenido left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work @ChrisChV!
Left some comments.

{providerName}
</span>
<span className="small">
<FormattedMessage {...messages.completed} values={{ date: completedOn }} />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are passing the completedOn as a plain string here.

Suggested change
<FormattedMessage {...messages.completed} values={{ date: completedOn }} />
<FormattedMessage
{...messages.completed}
values={{
date: (
<FormattedDate
value={completedOn}
day="numeric"
month="short"
year="numeric"
timeZone="UTC" // FIXME: get user timezone
/>
),
}}
/>

Then, we would probably need an endpoint to get the user timezone. The course code gets it from /api/course_home/v1/course_metadata/

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 0a4c273

Comment on lines +41 to +43
<span className="h4">
{displayName}
</span>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: <span className="h4"> gives the visual size but no heading semantics

Suggested change
<span className="h4">
{displayName}
</span>
<h3 className="h4">
{displayName}
</h3>

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 0a4c273

import { NewsModeIcon } from './NewsModeIcon';

export interface CertificateCardProps extends PathwayAchievementData {
categoryLabel?: string;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is safe to assume we will always have that.

Suggested change
categoryLabel?: string;
categoryLabel: string;

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 0a4c273

import { Button, Icon, Stack } from '@openedx/paragon';
import { FormattedMessage } from '@edx/frontend-platform/i18n';

import { PathwayAchievementData } from '@src/pathways/data/types';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

Suggested change
import { PathwayAchievementData } from '@src/pathways/data/types';
import type { PathwayAchievementData } from '@src/pathways/data/types';

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 0a4c273

pathwayCertificate: {
id: 'learning.pathways.certificate-card.pathway-certificate',
defaultMessage: '{categoryLabel} certificate',
description: 'Subtite of the Pathway certificate',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Suggested change
description: 'Subtite of the Pathway certificate',
description: 'Subtitle of the Pathway certificate',

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 0a4c273

itemCertificate: {
id: 'learning.pathways.certificate-card.item-certificate',
defaultMessage: 'Certificate',
description: 'Subtite of the Item certificate',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Suggested change
description: 'Subtite of the Item certificate',
description: 'Subtitle of the Item certificate',

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 0a4c273

completed: {
id: 'learning.pathways.certificate-card.completed',
defaultMessage: 'Completed on {date}',
description: 'Subtite of the Pathway certificate',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: 'Subtite of the Pathway certificate',
description: 'Completion date for the course',

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 0a4c273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging

Projects

Status: Waiting on Author
Status: In Progress

Development

Successfully merging this pull request may close these issues.

5 participants