Repository navigation
Conversation
Show, above the learning header, the pathways that include the current course and in which the learner is enrolled. The labels that do not fit are moved to a "+N" popover, following the same logic as the course card strip in the learner dashboard. - Add the `course-pathways` data layer: `getPathwaysByCourse` in the API layer, which returns an empty map until the backend exists, and the `useCoursePathways` hook, which extracts the course pathways from it. - Add the `CoursePathwaysStrip` and `MorePathwaysPopover` components and the `useVisiblePathways` hook to split the visible and hidden pathways. - Add the `org.openedx.frontend.learning.course_pathways_strip.v1` plugin slot, rendered by `TabPage` once the course page has loaded. - Add mock pathways as test fixtures.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
…s strip and request its pathways
…over and align it to the end of the strip Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ip slot below the course header
…p in its own pathways-strip folder
…ourse pathways strip to them
…ate earned in the pathway
|
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
… link to its achievements
8ddaef9 to
304147d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2233 +/- ##
==========================================
+ Coverage 96.16% 96.34% +0.18%
==========================================
Files 368 398 +30
Lines 6019 6317 +298
Branches 1486 1481 -5
==========================================
+ Hits 5788 6086 +298
Misses 222 222
Partials 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@ChrisChV @cassiezamparini Since this PR is part of Pathways, can we consider it approved from a product perspective? |
|
Leaving this to @ChrisChV to answer :) |
@itsjeyd It's in internal dev review |
| <h1> | ||
| <FormattedMessage {...messages.gradesTitle} /> | ||
| </h1> |
There was a problem hiding this comment.
This is already inside an <h1>. We can try to use the h1 class to match the design
| <h1> | |
| <FormattedMessage {...messages.gradesTitle} /> | |
| </h1> | |
| <h2> | |
| <FormattedMessage {...messages.gradesTitle} /> | |
| </h2> |
| }, | ||
| achievementsInfoDescription: { | ||
| id: 'learning.pathways.progress.achievements-info.description', | ||
| defaultMessage: "Showcase your certificates on LinkedIn, or your resume today. Access your bootcamp's achievements below.", |
There was a problem hiding this comment.
We need to add the categoryLabel instead of bootcamp here.
| gradesViewDetails: { | ||
| id: 'learning.pathways.progress.grades.table.view-details', | ||
| defaultMessage: 'View details', | ||
| description: 'Label for the Viewd details links in the grades table', |
There was a problem hiding this comment.
typo
| description: 'Label for the Viewd details links in the grades table', | |
| description: 'Label for the View details links in the grades table', |
| }, | ||
| achievementsInfoEmptyDescription: { | ||
| id: 'learning.pathways.progress.achievements-info.empty.description', | ||
| defaultMessage: 'No certificates earned yet. ', |
There was a problem hiding this comment.
typo
| defaultMessage: 'No certificates earned yet. ', | |
| defaultMessage: 'No certificates earned yet.', |
| import { FormattedMessage, useIntl } from '@edx/frontend-platform/i18n'; | ||
| import { DataTable } from '@openedx/paragon'; | ||
|
|
||
| import { GradeData } from '@src/pathways/data/types'; |
There was a problem hiding this comment.
nit
| import { GradeData } from '@src/pathways/data/types'; | |
| import type { GradeData } from '@src/pathways/data/types'; |
| }, | ||
| completionDescription: { | ||
| id: 'learning.pathways.progress.completion.description', | ||
| defaultMessage: 'This represents how many courses you have completed in this {categoryLabel}.', |
There was a problem hiding this comment.
nit
| defaultMessage: 'This represents how many courses you have completed in this {categoryLabel}.', | |
| defaultMessage: 'This represents how many items you have completed in this {categoryLabel}.', |
|
|
||
| expect(screen.getByRole('heading', { name: 'Bootcamp completion' })).toBeInTheDocument(); | ||
| expect( | ||
| screen.getByText('This represents how many courses you have completed in this Bootcamp.'), |
There was a problem hiding this comment.
nit
| screen.getByText('This represents how many courses you have completed in this Bootcamp.'), | |
| screen.getByText('This represents how many items you have completed in this Bootcamp.'), |
| additionalColumns={[ | ||
| { | ||
| id: 'action', | ||
| Cell: DetailsCell, |
There was a problem hiding this comment.
For acessibility:
| Cell: DetailsCell, | |
| id: 'action', | |
| Header: <span className="sr-only">{intl.formatMessage(messages.gradesActionsColumn)}</span>, | |
| Cell: DetailsCell, |
| const DetailsCell = ({ row }: { row: { original: GradeData } }) => ( | ||
| <Link to={row.original.detailsUrl}> | ||
| <FormattedMessage {...messages.gradesViewDetails} /> | ||
| </Link> | ||
| ); |
There was a problem hiding this comment.
We have the same message here for all lines. This could be an issue for acessibility.
Adding an aria-label would fix it:
| const DetailsCell = ({ row }: { row: { original: GradeData } }) => ( | |
| <Link to={row.original.detailsUrl}> | |
| <FormattedMessage {...messages.gradesViewDetails} /> | |
| </Link> | |
| ); | |
| const DetailsCell = ({ row }: { row: { original: GradeData } }) => { | |
| const intl = useIntl(); | |
| return ( | |
| <Link | |
| to={row.original.detailsUrl} | |
| aria-label={intl.formatMessage(messages.gradesViewDetailsFor, { courseName: row.original.displayName })} | |
| > | |
| <FormattedMessage {...messages.gradesViewDetails} /> | |
| </Link> | |
| ); | |
| }; |
And something like the bellow in the messages.ts:
gradesViewDetailsFor: {
id: 'learning.pathways.progress.grades.table.view-details-for',
defaultMessage: 'View details for {courseName}',
description: 'Accessible label for the View details links in the grades table',
},
Description
Review only the changes of this PR: open-craft/frontend-app-learning@chris/fal-4398-pathway-achievements-page...chris/fal-4398-pathway-progress-page
It adds the content of the Progress tab of the pathway pages
Supporting Information
Testing Instructions
View achievementsin the side card and verify that it goes to the Achievements tabNotes
Stack