Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Annotate dataset artifacts in LaminDB with everything the OpenProblems website shows about a dataset, so it can be rendered from the instance. Used for the test resources for now; it moves to
coreonce it settles.lamin_annotate.annotate_artifact():src/apifile format with every slot (obs,var,uns,layers,obsm,obsp,varm) and attaches it, so the hub documents the whole file.obs,varandunsare validated withAnnDataCuratorfirst, since lamindb can't curate the other slots yet; their validation stays invalidate_dataset.obs(organism, cell type, tissue, disease, sex, assay, development stage, ethnicity) through bionty. Mouse development stages are looked up in MmusDv, and only CELLxGENE placeholders (na,unknown) are created by hand.dataset_*metadata andnormalization_idfromuns, plusn_vars,n_donors,n_batches,n_hvg,n_pca_componentsandknn_n_neighborsas feature values, and setsn_observationsobs_counts(cells per category) andstructure(per slot: name, type, dtype, shape and the description from the spec, read from the zarr metadata only)common/library.bibasln.Referencerecords with their DOI, and labels the modality (scrnaseq)The readers for the structure and summary are per file format;
anndata_zarris the only one for now, MuData, SpatialData, data frames and JSON/YAML follow later. Features are grouped per slot (OpenProblems>obs,uns, ...), since e.g.dataset_idmeans something else inobsanduns.The notebooks pass the file format of each step (
helpers.SCRNASEQ_SPECS) and record the workflow parameters on their run. Re-running them annotated the existing test resources inopenproblems/data-devwithout creating new versions, e.g. the mouse pancreas dataset.Two upstream issues worked around here: bionty's Ensembl organism source lists mouse strains under the same
NCBITaxon:10090, and lamindb'ssave()then recurses forever on the duplicate uids, so the species is registered before curating.Issue ticket number and link
n/a
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!