Repository navigation
fix(krater): match the quoted edge ping env arg in the weft check - #109
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red since #108, so every lab host refuses to switch ("a check failed; not switching to it" on weft).Cause: the new
krater-weftcheck greps the staging worker's start script for--env KRATER_EDGE_PING_EXPECTED=true.modules/krater/instance.nixrenders each pair withlib.escapeShellArg, which quotes it because of the=. The script holds--env 'KRATER_EDGE_PING_EXPECTED=true', so the grep never matched.Fix: grep for the quoted form. The setting itself is correct.
Tested: CI passed on this exact commit on the #108 branch (run 43897954262). A review confirmed the pattern matches the rendered script and that the production negative check reads the right file.