Skip to content

fix(krater): match the quoted edge ping env arg in the weft check - #109

Merged
jaspermayone merged 1 commit into
mainfrom
claude/fix-krater-weft-edge-ping-test
Nov 16, 2026
Merged

jaspermayone merged 1 commit into
mainfrom
claude/fix-krater-weft-edge-ping-test

Conversation

@jaspermayone

Copy link
Copy Markdown
Member

main is red since #108, so every lab host refuses to switch ("a check failed; not switching to it" on weft).

Cause: the new krater-weft check greps the staging worker's start script for --env KRATER_EDGE_PING_EXPECTED=true. modules/krater/instance.nix renders each pair with lib.escapeShellArg, which quotes it because of the =. The script holds --env 'KRATER_EDGE_PING_EXPECTED=true', so the grep never matched.

Fix: grep for the quoted form. The setting itself is correct.

Tested: CI passed on this exact commit on the #108 branch (run 43897954262). A review confirmed the pattern matches the rendered script and that the production negative check reads the right file.

@jaspermayone
jaspermayone requested a review from a team November 16, 2026 15:42
@jaspermayone
jaspermayone merged commit e7e1a37 into main Nov 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant