machine: the fingerprint is one hash, and Incoming one field - #97
Merged
Merged
Conversation
identity() was split out so FingerprintCache could memoise the file sums alone; the cache is gone, and identity was a second length-prefixed writer whose output was hashed again. The shape, the topology and the host CPU are written into the fingerprint's hash directly. Every fingerprint changes with it: no checkpoint taken before this resumes after it. IncomingDefer and Incoming were two fields for -incoming's one argument, with a validate case to keep them apart. Incoming takes "defer", QEMU's own word, as the CLI already did. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
aledbf
added a commit
that referenced
this pull request
Oct 2, 2026
fingerprint-diff compared qemu, kernel, bios and pvh, so a change to what machine/ hashes or how - #97 folded the fingerprint into one hash - moved every fingerprint while the verdict said checkpoints still resume. hack/release records Fingerprint itself, of the shipped tree with a named CPU, as fingerprint_sha256, and the verdict compares it with the rest. Co-authored-by: Claude Opus 5.5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
identity()existed so FingerprintCache could memoise the file sums alone; the cache went in 2d9b7e3, and identity stayed as a second length-prefixed writer whose string was hashed again asidentity=<len>:.... Shape, topology and host CPU are now written into the fingerprint's hash directly. Every fingerprint changes: no checkpoint saved before resumes after. Agreed: nothing is in production.IncomingDefer boolandIncoming stringwere two fields for one-incomingargument, plus a validate case to keep them apart.Incoming = "defer"is QEMU's own word, as--incoming deferalready was on the CLI. spin sets IncomingDefer in one place (internal/runner/qemu/spec.go); its PR follows this one.Local mutate, empty SPIN_MACHINE_OUTPUT: 38 refused, 0 survived.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.