Skip to content

Let the Sourceful app sign a user up again after they left the list - #4

Merged
wachtelhund merged 1 commit into
mainfrom
lift-app-unsubscribe-suppression
Nov 18, 2026
Merged

wachtelhund merged 1 commit into
mainfrom
lift-app-unsubscribe-suppression

Conversation

@wachtelhund

Copy link
Copy Markdown
Contributor

App Tester saw subscribed: false immediately after a 200 subscribe against app.sourceful.energy. This is not double opt-in (v1 signs up at once) and not a cache (status is no-store). Production logs for the test showed a real Utskick subscribe and a successful status call, with no fail-open errors.

POST /subscribe always answers { ok: true }, including when a list-scoped unsubscribe suppression drops the sign-up. Status then correctly reads false. That rule stays for website forms: they cannot tell the person from someone typing their address.

The Sourceful app form is different. The web-app only sends the signed-in user's email, so someone who turns the newsletter off and later opts in again should be put back on app-users.

Change

In subscribe(), when source === 'sourceful-app', delete a list-scoped unsubscribe suppression for that address in the same batch, then insert as usual. Bounce, complaint, Mailchimp-cleaned, and * suppressions are never lifted. Website forms are unchanged.

Tests

npm test: 226 tests passed, including:

  • the app can sign the same user up again after they left that list
  • bounce still blocks the app form
  • website forms still cannot lift an unsubscribe

Do not merge this PR from this author; leaving that to Hampus. The Worker needs a deploy after merge for production status to follow a re-subscribe.

POST /subscribe always answered ok, even when a list-scoped unsubscribe
suppression dropped the sign-up, so GET /subscribe/status stayed false
right after an app opt-in. Website forms still cannot lift that
suppression. Bounce, complaint, and Mailchimp-cleaned are unchanged.
@wachtelhund
wachtelhund merged commit b9d7c1c into main Nov 18, 2026
1 check passed
wachtelhund added a commit that referenced this pull request Nov 18, 2026
…e list. (#4)" (#5)

This reverts commit b9d7c1c.

Co-authored-by: wachtelhund <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant