Repository navigation
Let the Sourceful app sign a user up again after they left the list - #4
Merged
Merged
Conversation
POST /subscribe always answered ok, even when a list-scoped unsubscribe suppression dropped the sign-up, so GET /subscribe/status stayed false right after an app opt-in. Website forms still cannot lift that suppression. Bounce, complaint, and Mailchimp-cleaned are unchanged.
wachtelhund
added a commit
that referenced
this pull request
Nov 18, 2026
…e list. (#4)" (#5) This reverts commit b9d7c1c. Co-authored-by: wachtelhund <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App Tester saw
subscribed: falseimmediately after a 200 subscribe againstapp.sourceful.energy. This is not double opt-in (v1 signs up at once) and not a cache (status isno-store). Production logs for the test showed a real Utskick subscribe and a successful status call, with no fail-open errors.POST /subscribealways answers{ ok: true }, including when a list-scopedunsubscribesuppression drops the sign-up. Status then correctly readsfalse. That rule stays for website forms: they cannot tell the person from someone typing their address.The Sourceful app form is different. The web-app only sends the signed-in user's email, so someone who turns the newsletter off and later opts in again should be put back on
app-users.Change
In
subscribe(), whensource === 'sourceful-app', delete a list-scopedunsubscribesuppression for that address in the same batch, then insert as usual. Bounce, complaint, Mailchimp-cleaned, and*suppressions are never lifted. Website forms are unchanged.Tests
npm test: 226 tests passed, including:Do not merge this PR from this author; leaving that to Hampus. The Worker needs a deploy after merge for production status to follow a re-subscribe.