Repository navigation
Conversation
Fixture: the hierarchical 110x14 table reported by SSB against 0.6, where the fractional variant aborted the R session on Windows (MOD(1,5,0,0,0)) while the integer variant ran. The test runs both variants through tab_rtauargus and pins the contract (completes, 429 a priori secrets stay secret, finite published values). This branch still pins the pre-fix engine (c147eca): the Windows CI job is the differential-diagnosis run for the reported abort.
cspSCIP.sol, sdc.lp and sdcnet.lp are written to the working directory by the CSP solver (Cspmain.c) when the engine test suite runs, like the other already-ignored cspSCIP.* scratch files.
Serialize the original parquet data frames as portable RDS fixtures. R's read.csv changes 160 decimal doubles at the last bit and changes MOD's result. Keep the same-data truncated control and print the Windows status summary in test logs.
Owner
Author
|
Superseded by #22: its modular fixtures, Arrow-exact RDS regression, controlled comparison and scratch-file ignore are all present there. The old-pin Windows source check passed; no need to keep a separate diagnostic PR open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Regression test for the fractional-table abort reported by SSB
against 0.6: their hierarchical 110x14 table (values to ~9e9 with
machine-precision fractional parts, 429 a priori secrets, two hrc
hierarchies) with
tab_rtauargus(..., suppress = "MOD(1,5,0,0,0)").On Windows 0.6 the fractional run aborts the R session; the integer
variant and the macOS runs complete.
What this branch does
plus the two hierarchy files) and a testthat test running both the
fractional and the integer variant through
tab_rtauargus.secret, remaining cells split visible/secondary, published values
finite.
tab_rtauarguswrites a uniformized*_unif.hrcnext to itsinput.
Note: the engine pin is deliberately old
This branch keeps the pre-fix engine pin (c147eca). The Windows CI
job is the differential-diagnosis run: if it aborts there, the
reported crash is reproduced on the exact CRAN toolchain (R 4.5.3,
Rtools45, windows-2022). The follow-up pin bump to 9a3c0e8 (the
csp audit and crp maxsize fixes) is the second diagnostic.