Repository navigation
Conversation
Fixture: the hierarchical 110x14 table reported by SSB against 0.6, where the fractional variant aborted the R session on Windows (MOD(1,5,0,0,0)) while the integer variant ran. The test runs both variants through tab_rtauargus and pins the contract (completes, 429 a priori secrets stay secret, finite published values). This branch still pins the pre-fix engine (c147eca): the Windows CI job is the differential-diagnosis run for the reported abort.
The legacy intervalle port Int()-truncated the JJ bounds of the suppressed cell. The fixture's dominant a-priori cell (42.25) is forced by its margins to its own value while the table max (42.75) clips the upper bound to 42, so the pre-fix engine fails the audit LP (audit_jj rc -1) and the batch aborts. The fixed engine reports the exact fractional interval. Red on engine c147eca (0.6.1), green on 9a3c0e8.
cspSCIP.sol, sdc.lp and sdcnet.lp are written to the working directory by the CSP solver (Cspmain.c) when the engine test suite runs, like the other already-ignored cspSCIP.* scratch files.
Serialize the original parquet data frames as portable RDS fixtures. R's read.csv changes 160 decimal doubles at the last bit and changes MOD's result. Keep the same-data truncated control and print the Windows status summary in test logs.
Re-point the release pin to the final engine master (9a3c0e8 + crp gitignore hygiene). Code-identical to 9a3c0e8, which already passed the Windows Arrow-exact MOD check; this confirms the exact pin.
trygu
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Second leg of the Windows-abort diagnosis (with PR #20, which keeps
the old pin):
crp maxsize fix (engine PR encoding of TA files - bug fixed InseeFrLab/rtauargus#41), both TDD-tested in the engine repo.
Oeyvind's scenario on the fixed engine.
cast bug at the R level: the fixture's dominant a-priori cell is
forced by its margins to its own fractional value while the table
max clips the upper bound, so the pre-fix engine aborts the batch
with "audit_jj failed (rc=-1)" and the fixed engine reports the
exact interval.
the commit the 0.6.2 release tags from.