feat(stovepipe): Store terminal build ID - #752
Merged
Merged
Conversation
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-terminal-build-marker
branch
from
September 29, 2026 00:58
e0577da to
3c70ced
Compare
1 task done
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-terminal-build-marker
branch
from
September 29, 2026 01:18
3c70ced to
14250bc
Compare
prathshenoy
added a commit
that referenced
this pull request
Sep 29, 2026
Summary: **What**: - Add BuildStore.GetTerminalBuild to retrieve the build that established a request's terminal state. **Why**: - Let downstream consumers find the selected build without adding a reverse reference to Request. - This PR builds on #752, which marks and uniquely selects the terminal build. Test Plan: - [x] Add unit tests. Revert Plan: - Revert this PR if the terminal-build marker model is not adopted, because this lookup depends on that marker to identify a build. Jira Issues: None
prathshenoy
added this pull request to stack #755
September 29, 2026 01:24
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-terminal-build-marker
branch
from
September 29, 2026 01:28
14250bc to
3c70ced
Compare
1 task done
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-terminal-build-marker
branch
from
September 29, 2026 01:30
3c70ced to
8e5cd60
Compare
This was referenced Sep 29, 2026
prathshenoy
marked this pull request as ready for review
September 29, 2026 13:34
prathshenoy
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
September 29, 2026 13:34
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-terminal-build-marker
branch
from
September 29, 2026 17:15
8e5cd60 to
d358f0b
Compare
prathshenoy
changed the title
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-terminal-build-marker
branch
2 times, most recently
from
September 29, 2026 17:27
d7d54e4 to
4ab6eaf
Compare
mnoah1
approved these changes
Sep 29, 2026
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-terminal-build-marker
branch
from
September 29, 2026 22:22
4ab6eaf to
2ddf455
Compare
prathshenoy
changed the title
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-terminal-build-marker
branch
from
September 29, 2026 22:28
2ddf455 to
ab6f957
Compare
**What**: - Add the terminal build identity to each completed request. - Persist the identity with the request lifecycle state. **Why**: - Make the selected build directly available to request consumers. - Keep the schema change additive and migration-compatible.
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-terminal-build-marker
branch
from
September 29, 2026 22:30
ab6f957 to
e04151e
Compare
behinddwalls
deleted the
prath.shenoy/stovepipe-terminal-build-marker
branch
September 30, 2026 00:10
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What:
Why:
Test Plan
Revert Plan
Issues
Stack