Skip to content

feat(stovepipe): Record terminal build history - #756

Merged
prathshenoy merged 1 commit into
prath.shenoy/stovepipe-terminal-build-lookupfrom
prath.shenoy/stovepipe-terminal-build-history
Sep 30, 2026
Merged

feat(stovepipe): Record terminal build history#756
prathshenoy merged 1 commit into
prath.shenoy/stovepipe-terminal-build-lookupfrom
prath.shenoy/stovepipe-terminal-build-history

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

What:

  • Record the terminal build ID with a request's terminal history when a build establishes the state.

Why:

  • Preserve durable history showing which build established the request’s final state.

Test Plan

  • Add unit tests.

Revert Plan

  • Revert this PR. Terminal history is supplementary and does not change request state or project resolution.

Issues

Stack

  1. feat(stovepipe): Store terminal build ID #752
  2. feat(stovepipe): Persist terminal build ID #754
  3. @ feat(stovepipe): Record terminal build history #756
  4. feat(stovepipe): Pass terminal build to resolver #757
  5. docs(stovepipe): Document terminal build IDs #758

@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-history branch from 5f58341 to 1e807ee Compare September 29, 2026 01:30
@prathshenoy
prathshenoy added this pull request to stack #755 September 29, 2026 01:31
This was referenced Sep 29, 2026
Merged
Merged
Merged
Merged
@prathshenoy
prathshenoy marked this pull request as ready for review September 29, 2026 13:34
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-history branch from 1e807ee to 8f33cbb Compare September 29, 2026 17:17
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-history branch from 8f33cbb to 2dd17d6 Compare September 29, 2026 17:20
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-history branch from 2dd17d6 to 259b2c6 Compare September 29, 2026 17:27
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-history branch from 259b2c6 to 28a3220 Compare September 29, 2026 22:22
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-history branch from 28a3220 to cebb25c Compare September 29, 2026 22:28
@prathshenoy
feat(stovepipe): Record terminal build history
904db19 
**What**:
- Include the terminal build identity in terminal request history.

**Why**:
- Retain the build that established each recorded request outcome.
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-history branch from cebb25c to 904db19 Compare September 29, 2026 22:30
@prathshenoy
prathshenoy added this pull request to the merge queue Sep 30, 2026
Merged via the queue into main with commit c3e14e2 Sep 30, 2026
16 checks passed
@behinddwalls
behinddwalls deleted the prath.shenoy/stovepipe-terminal-build-history branch September 30, 2026 00:10

This branch was successfully deployed

1 active deployment
stack-rebase — 904db19e Deployed Sep 30, 2026 by prathshenoy via Rebase Stack #545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnoah1 mnoah1 mnoah1 approved these changes
@behinddwalls behinddwalls Awaiting requested review from behinddwalls behinddwalls is a code owner
@sbalabanov sbalabanov Awaiting requested review from sbalabanov sbalabanov is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prathshenoy @mnoah1