Repository navigation
Conversation
Homebrew deprecated the legacy postflight Ruby block that GoReleaser generates around homebrew_casks hooks.post.install, so every brew install/upgrade/untap of the urlscan-cli cask prints: Warning: Calling `postflight` is deprecated! Use `postflight_steps` instead. The hook itself is a no-op: it strips com.apple.quarantine from the staged binary, but Homebrew downloads cask payloads with its own curl, which never applies the quarantine xattr. Dropping it removes the warning-generating stanza entirely.
emilstahl
added a commit
to emilstahl/homebrew-tap
that referenced
this pull request
Sep 21, 2026
Homebrew deprecated the legacy postflight Ruby block; brew prints a deprecation warning on every install/upgrade/untap of this cask. The block is also a no-op: it strips com.apple.quarantine from the staged binary, but Homebrew downloads cask payloads with its own curl, which never applies the quarantine xattr. Dropping it removes the warning-generating stanza entirely and matches what the next GoReleaser release will generate once the hook is removed from .goreleaser.yaml (urlscan/urlscan-cli#149).
Collaborator
|
Thanks but it doesn't work. $ goreleaser check
⨯ command failed error=yaml: found character that cannot start any tokenAlso I think it's better to wait GoReleaser v2.19. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GoReleaser's cask template wraps
homebrew_casks.hooks.post.installin Homebrew's deprecatedpostflightRuby block (goreleaser/goreleaser#6870 — fix PR was closed unmerged). So every release regeneratesCasks/urlscan-cli.rbin homebrew-tap with a stanza that now prints on everybrew install/upgrade/untap:I've also opened urlscan/homebrew-tap#1 to fix the currently-generated cask directly.
Why delete rather than migrate
The hook strips
com.apple.quarantinefrom the stagedurlscanbinary. But Homebrew downloads cask payloads with its own curl download strategy, which never applies the quarantine xattr (that's set by LaunchServices-aware apps like browsers, not curl). The staged file the hook operates on can never carry the attribute, so the hook is a no-op — dead code that exists only to emit a deprecated stanza.If you'd rather keep the belt-and-suspenders strip anyway, the migration-safe variant is
custom_block(GoReleaser'shookscan't emitpostflight_stepssince the wrapper stanza is hardcoded in its template):Happy to switch this PR to that form if preferred — deletion is just the simpler end state.
Changes
hooks.post.install(and its doc-reference comment) from.goreleaser.yaml. Nothing else.After this merges, the next
goreleaser releaseregenerates the tap cask without anypostflightstanza, and the warning is gone for good.