[DavyLandman]

This PR continues the work in #2499 (that was merged to main a bit too soon) to fix #2496

• removes subtype relation between start[X] and X (in asubtype, alub, aglb)
• removes subtype relation between start symbols and regular symbols (lists)
• removes special cases for field selection and field update on .top
• removes special cases for \start non-terminal whereever the contextFreeSyntax role is expected by adding a role field to the start AType
• adds an implicit/automatic declaration, for every syntax rule for X that has a start modifier:
  • start production rule start[X] = X;
  • top field start[X] = X top;
  • layout wrapping start[X] = L X L;
• removes more special cases in the back-end
• removes missed special cases in the collector for pattern matching
• removed API functions isStart* and getStart* that were used for detecting the old special cases

Together these changes solve a small number of known issues with start symbols, and a larger number of previously undetected issues.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45%. Comparing base (ce84e35) to head (cf5b275).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##              main   #2551   +/-   ##
=======================================
  Coverage       45%     45%           
- Complexity    6806    6810    +4     
=======================================
  Files          844     844           
  Lines        68826   68826           
  Branches     10040   10040           
=======================================
+ Hits         31420   31422    +2     
+ Misses       35015   35008    -7     
- Partials      2391    2396    +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jurgenvinju]

Looks good. Needs an integration test.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[DavyLandman]

@jurgenvinju this is your own code ;) I merely did some git cooking to extract it from a different PR.

[jurgenvinju]

@PaulKlint should we use typepal's "predefine" functionality instead of constructing an artificial field location for "top"?

Same for the entire start rule. Should we use predefine for that as well?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud