Repository navigation
Add CI with browser tests - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pickify had no CI. This adds a GitHub Actions workflow that runs on every pull request and every push to master, with two jobs:
The browser tests (e2e/) run against a production build with every /api call answered by a fake API in the browser and a stand-in YouTube player. They need no database, Last.fm or YouTube, and use made-up songs with no covers. They check:
New npm script:
npm run testBrowser. New dev dependency: @playwright/test. README has a section on running them.Testing: all 15 browser tests pass locally (16 with one skipped on phones), and three repeated runs were stable. Typecheck, lint and all 168 unit tests pass. This PR's own CI run is the first real run of the workflow.
Generated by Claude Code