Skip to content

[26.04_linux-nvidia-bos] fs/resctrl: Report unknown schemata domains - #709

Open
nirmoy wants to merge 1 commit into
NVIDIA:26.04_linux-nvidia-bosfrom
nirmoy:codex/nvbug-7080254
Open

nirmoy wants to merge 1 commit into
NVIDIA:26.04_linux-nvidia-bosfrom
nirmoy:codex/nvbug-7080254

Conversation

@nirmoy

@nirmoy nirmoy commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

A schemata write naming an unknown domain returns EINVAL, but last_cmd_status reports ok because parse_line() does not record a diagnostic. Report the invalid domain ID while preserving the error return and staged-configuration cleanup.

Prior validation on Vera with native 64K ARM64 builds (before this rebase):

  • BOS release source 2cfa605be955, before/after: all six cases passed with the expected results, including unknown L3/MB domains and a valid assignment followed by an invalid domain. Existing diagnostics and unchanged root/group schemata were verified.
  • Mainline 067c5c24cef23 (7.4-rc2), before/after: reproduced the L3 issue and verified the same fix; valid and malformed-domain controls passed. MB was unavailable on this node and was skipped on mainline.
  • Raw dmesg snapshots were identical before/after each completed BOS test run. Native Image/modules builds, checkpatch and whitespace checks passed.

Rebased onto BOS tip 339666084c9c. The resctrl source file is identical between the old and new bases, and the one-line diff matches the patch posted upstream. The commit includes its Fixes: tag and (backported from ...) provenance.

Local whitespace and patch-equivalence checks passed after rebasing. The prior build and Vera runtime results above have not been rerun for this rebased commit.

@nirmoy

nirmoy commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator Author

BaseOS Kernel Review

Tip

✅ Review passed

No issues found across the reviewed commits.

Findings: none

🔍 Review artifacts

📦 Build checks — 🔴 2/4 passed

Note

Build reports and debs are retained for 10 days after the PR closes.

  • 🔴 PR Illustrated: failed — Published explanation could not be verified.
Review metadata
  • Reviewed head: 099802082d60
  • Overall status: build partially successful
  • Build checks: 2/4 passed

This comment is maintained by BaseOS Reviewer and updated when the GitHub watcher publishes a newer review.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

PR Validation Report

Patchscan ✅ No Missing Fixes

All cherry-picked commits checked — no missing upstream fixes found.

PR Lint ❌ Errors found

Details
Checking 1 commits...

Cherry-pick digest:
┌──────────────┬──────────────────────────────────────────────────────────────────┬────────────┬─────────┬───────────────────────────┐
│ Local        │ Referenced upstream / Patch subject                              │ Patch-ID   │ Subject │ SoB chain                 │
├──────────────┼──────────────────────────────────────────────────────────────────┼────────────┼─────────┼───────────────────────────┤
│ 099802082d60 │ fs/resctrl: report unknown schemata domains                      │ match      │ found   │ ok, backporter: nirmoyd   │
└──────────────┴──────────────────────────────────────────────────────────────────┴────────────┴─────────┴───────────────────────────┘

Lint: all checks passed.

PR metadata:
E: PR targets 26.04_linux-nvidia-bos but body has no https://bugs.launchpad.net/... link

@nirmoy
nirmoy requested a review from fyu1 November 11, 2026 13:20
@clsotog

clsotog commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Acked-by: Carol L Soto <[email protected]>

@jamieNguyenNVIDIA

Copy link
Copy Markdown
Collaborator

Acked-by: Jamie Nguyen <[email protected]>

@fyu1

fyu1 commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

@nirmoy

Could you please send this patch to LKML and resctrl maintainers?

Reviewed-by: Fenghua Yu [email protected]

Thanks.

@jamieNguyenNVIDIA

Copy link
Copy Markdown
Collaborator

@fyu1

I didn’t realize this bug existed upstream too. Agreed with Fenghua on sending this to LKML.

@nvmochs

nvmochs commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

@nirmoy Perhaps sent to the ML and then update this SAUCE patch with LKML link? You may want to consider sending it with a fixes tag. Please also submit the same change for 7.0-lts and 7.3-hwe.

@nvidia-bfigg
nvidia-bfigg force-pushed the 26.04_linux-nvidia-bos branch from 2ab63b5 to 3396660 Compare November 14, 2026 13:03
A schemata write to an unknown domain returns -EINVAL without setting
last_cmd_status. The status buffer is cleared before parsing, so reading
last_cmd_status after the failed write incorrectly reports "ok".

Report the invalid domain before returning -EINVAL, matching the existing
I/O allocation parser diagnostic.

Fixes: c377dcf ("x86/intel_rdt: Add diagnostics when writing the schemata file")
Signed-off-by: Nirmoy Das <[email protected]>
(backported from https://lore.kernel.org/r/[email protected])
Signed-off-by: Nirmoy Das <[email protected]>
@nirmoy
nirmoy force-pushed the codex/nvbug-7080254 branch from 0d2487d to 0998020 Compare November 19, 2026 12:56
@nirmoy
nirmoy marked this pull request as ready for review November 19, 2026 13:09
@nirmoy

nirmoy commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator Author

updated the PR with lore url https://lore.kernel.org/all/[email protected]/

@nvmochs

nvmochs commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

Thanks Nirmoy!

Acked-by: Matthew R. Ochs <[email protected]>


@nirmoy Please also open a PR with the same backport to the other kernels where this is vulnerable (likely 7.3 and possibly 7.0-lts).

@clsotog

clsotog commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

My ack stands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants