Repository navigation
Conversation
BaseOS Kernel ReviewTip ✅ Review passedNo issues found across the reviewed commits. Findings: none 🔍 Review artifacts
📦 Build checks — 🔴 2/4 passed
Note Build reports and debs are retained for 10 days after the PR closes.
Review metadata
This comment is maintained by BaseOS Reviewer and updated when the GitHub watcher publishes a newer review. |
PR Validation ReportPatchscan ✅ No Missing FixesAll cherry-picked commits checked — no missing upstream fixes found. PR Lint ❌ Errors foundDetailsChecking 1 commits... Cherry-pick digest: ┌──────────────┬──────────────────────────────────────────────────────────────────┬────────────┬─────────┬───────────────────────────┐ │ Local │ Referenced upstream / Patch subject │ Patch-ID │ Subject │ SoB chain │ ├──────────────┼──────────────────────────────────────────────────────────────────┼────────────┼─────────┼───────────────────────────┤ │ 099802082d60 │ fs/resctrl: report unknown schemata domains │ match │ found │ ok, backporter: nirmoyd │ └──────────────┴──────────────────────────────────────────────────────────────────┴────────────┴─────────┴───────────────────────────┘ Lint: all checks passed. PR metadata: E: PR targets 26.04_linux-nvidia-bos but body has no https://bugs.launchpad.net/... link |
|
|
|
|
|
Could you please send this patch to LKML and resctrl maintainers? Reviewed-by: Fenghua Yu [email protected] Thanks. |
|
I didn’t realize this bug existed upstream too. Agreed with Fenghua on sending this to LKML. |
|
@nirmoy Perhaps sent to the ML and then update this SAUCE patch with LKML link? You may want to consider sending it with a fixes tag. Please also submit the same change for 7.0-lts and 7.3-hwe. |
2ab63b5 to
3396660
Compare
A schemata write to an unknown domain returns -EINVAL without setting last_cmd_status. The status buffer is cleared before parsing, so reading last_cmd_status after the failed write incorrectly reports "ok". Report the invalid domain before returning -EINVAL, matching the existing I/O allocation parser diagnostic. Fixes: c377dcf ("x86/intel_rdt: Add diagnostics when writing the schemata file") Signed-off-by: Nirmoy Das <[email protected]> (backported from https://lore.kernel.org/r/[email protected]) Signed-off-by: Nirmoy Das <[email protected]>
0d2487d to
0998020
Compare
|
updated the PR with lore url https://lore.kernel.org/all/[email protected]/ |
|
Thanks Nirmoy!
@nirmoy Please also open a PR with the same backport to the other kernels where this is vulnerable (likely 7.3 and possibly 7.0-lts). |
|
My ack stands. |
A schemata write naming an unknown domain returns
EINVAL, butlast_cmd_statusreportsokbecauseparse_line()does not record a diagnostic. Report the invalid domain ID while preserving the error return and staged-configuration cleanup.Prior validation on Vera with native 64K ARM64 builds (before this rebase):
2cfa605be955, before/after: all six cases passed with the expected results, including unknown L3/MB domains and a valid assignment followed by an invalid domain. Existing diagnostics and unchanged root/group schemata were verified.067c5c24cef23(7.4-rc2), before/after: reproduced the L3 issue and verified the same fix; valid and malformed-domain controls passed. MB was unavailable on this node and was skipped on mainline.Rebased onto BOS tip
339666084c9c. The resctrl source file is identical between the old and new bases, and the one-line diff matches the patch posted upstream. The commit includes itsFixes:tag and(backported from ...)provenance.Local whitespace and patch-equivalence checks passed after rebasing. The prior build and Vera runtime results above have not been rerun for this rebased commit.