Repository navigation
test(spring-boot): [Sample Tests 9] Move the Boot 3 GraphQL tests into the module - #6295
Draft
runningcode wants to merge 2 commits into
Draft
runningcode wants to merge 2 commits into
runningcode wants to merge 2 commits into
Conversation
This was referenced Oct 20, 2026
📲 Install BuildsAndroid
|
This was referenced Oct 20, 2026
Draft
Draft
Draft
Draft
Draft
This was referenced Oct 20, 2026
Draft
Draft
Draft
Draft
runningcode
force-pushed
the
no/boot-jakarta-cache-metrics-flags-test
branch
from
October 21, 2026 09:19
fb628cd to
896122f
Compare
runningcode
force-pushed
the
no/boot-jakarta-graphql-test
branch
from
October 21, 2026 09:19
38bbcd5 to
5379114
Compare
Ports the jakarta sample's three GraphQL system tests to the integrationTest suite as plain JSON requests, so they no longer need the Apollo client: queries, a schema mapping, a mutation, resolver errors, and fields loaded through a batch mapping and a data loader. Errors are matched by their exception and tied to their transaction by trace ID, which both keeps two error tests apart on the shared server and checks that the error belongs to its request's transaction. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…r ids The sample's test asserted assigneeId and creatorId, which the query requests but the port didn't check. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
runningcode
force-pushed
the
no/boot-jakarta-cache-metrics-flags-test
branch
from
October 21, 2026 11:27
896122f to
c59a493
Compare
runningcode
force-pushed
the
no/boot-jakarta-graphql-test
branch
from
October 21, 2026 11:27
5379114 to
429aa76
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Sample Tests)
main)📜 Description
Ports the jakarta sample's
GraphqlGreetingSystemTest,GraphqlProjectSystemTestandGraphqlTaskSystemTestto theintegrationTestsuite insentry-spring-boot-jakarta, and deletes them from the sample. Each request's transaction must contain the matchinggraphqlspan:@BatchMappingand through a registeredDataLoader. The transaction has spans forTask.assigneeandTask.creator.How it differs from the sample:
/graphql. That removes the Apollo and OkHttp 4 dependencies these tests needed throughsentry-system-test-support.After this PR, the jakarta sample has one system test left:
KafkaQueueSystemTest.After a coverage audit against the sample's tests:
assigneeIdandcreatorId, which the sample asserted.💡 Motivation and Context
This continues the Spring Boot 3 pilot. The suite now runs 27 tests in about 6s.
💚 How did you test it?
:sentry-spring-boot-jakarta:checkpasses.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Port
KafkaQueueSystemTestusingEmbeddedKafka. The jakarta sample then has no tests, and it can come off the system-test runner and workflows.#skip-changelog