Skip to content

test(spring): [Sample Tests 28] Move the Spring 7 WAR sample's tests into the module - #6320

Draft
runningcode wants to merge 1 commit into
no/spring-jakarta-integration-testfrom
no/spring-7-integration-test
Draft

runningcode wants to merge 1 commit into
no/spring-jakarta-integration-testfrom
no/spring-7-integration-test

Conversation

@runningcode

@runningcode runningcode commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

PR Stack (Sample Tests)


📜 Description

Adds #6319's embedded-Tomcat integrationTest suite to sentry-spring-7, with io.sentry.spring7's packages. sentry-samples-spring-7's tests match the jakarta WAR sample's except for the URL, so the suite does too:

  • Person:
    • the failed request's error with its flag and request, the http.server transaction and the logs;
    • creating a person, with its profile.
  • Metrics: the servlet suites' test.

Spring Boot 4's BOM picks Spring 7 and Tomcat 11. As in #6319, Spring Boot itself stays off the suite's classpath, so Sentry's servlet container initializer takes its WAR path and adds SentrySpringFilter.

With no system tests left, the sample comes off the runner, the backend workflow and the Spring Boot 4 matrix. That was the matrix's last runner step, so the matrix also drops the Python setup, SENTRY_URL and the runner's log uploads. integrationTests includes the suite.

💡 Motivation and Context

Plain Spring 7, without Boot, now runs end to end in the module. The suite runs 5 tests in a few seconds.

💚 How did you test it?

  • All 5 tests pass on Spring Boot 4.1.0's BOM (Spring 7.0.8, Tomcat 11.0).
  • They also pass with the catalog set to 4.0.0.
  • The suite's runtime classpath has no Spring Boot jar.
  • Without Sentry's initializer, the error has no request.
  • :sentry-spring-7:check passes, and the sample's WAR still builds.

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

The sentry-spring (javax) WAR sample.

#skip-changelog

🤖 Generated with Claude Code

This was referenced Oct 20, 2026
@sentry

sentry Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.61.0 (1) release

⚙️ sentry-android Build Distribution Settings

Adds sentry-spring-jakarta's embedded-Tomcat integrationTest suite to
sentry-spring-7, with the module's packages. The sample's tests were
the jakarta WAR sample's, so the suite is too. Spring Boot 4's BOM picks
Spring 7 and Tomcat 11.

The sample has no system tests left, so it comes off the system-test
runner, the backend workflow and the Spring Boot 4 matrix. That was the
matrix's last runner step, so it drops the Python setup and the runner's
logs too. integrationTests includes the suite.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@runningcode
runningcode force-pushed the no/spring-jakarta-integration-test branch from 0fb9338 to e7c763d Compare October 21, 2026 11:27
@runningcode
runningcode force-pushed the no/spring-7-integration-test branch from d5e9509 to c5ff6d9 Compare October 21, 2026 11:27

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant